fix: set default cell value using column's parseValue function - #2914
Merged
Conversation
enjeck
force-pushed
the
fix/view-fe-filter
branch
2 times, most recently
from
August 25, 2026 02:11
47ae622 to
fc4294e
Compare
Signed-off-by: Enjeck C. <patrathewhiz@gmail.com>
enjeck
force-pushed
the
fix/view-fe-filter
branch
from
August 25, 2026 02:12
fc4294e to
afc059a
Compare
samin-z
self-requested a review
August 28, 2026 09:22
samin-z
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A cell that has never been given a value has no stored entry and inherits the column default when read. The display (
TableRow.vuegetCellValue) and the server-side View filter (Row2Mapper.phpincludeDefault) both honor that default, but the quick filter and search in the default table view (NcTable.vuegetSearchedAndFilteredRows) did not. They read an unset cell asnull, so rows that visibly show their default value were dropped, and the same filter returned fewer rows in the table than in an equivalent View. The fix falls back to the column default for an unset cell, the same way the display does.parseValueconverts the stored default form (e.g."0") into the cell form (0) so lookups and comparisons match. Client-side only, no backend or migration change.to reproduce:
With 10 untouched rows, 2 explicit "Active", and 1 explicit "Inactive", the table filter returns 2 while the View returns 12. After the fix both return 12.
🖼️ Screenshots
🏁 Checklist
/backport to stableX.X🤖 AI (if applicable)